Edit __init__.py with utf8 encode to fix TypeError#8
Open
RBBlackstone wants to merge 1 commit intomr-rigden:masterfrom
Open
Edit __init__.py with utf8 encode to fix TypeError#8RBBlackstone wants to merge 1 commit intomr-rigden:masterfrom
RBBlackstone wants to merge 1 commit intomr-rigden:masterfrom
Conversation
RBBlackstone
commented
Sep 3, 2019
Changed line 8:
summary = output.split("Summary:")[-1]
to
summary = output.decode('utf8').split("Summary:")[-1]
This is in response to the error:
TypeError: a bytes-like object is required, not 'str' on line 8 of __init__.py
It appears to be a change in python in version 3
Part of the story is here:
https://docs.python.org/3/howto/pyporting.html
see "Text versus binary data"
There is another branch that achieves this by specifying utf8 output from the subprocess. Both work. I am not sure of best practice.
-RB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.