feat(parser): Generate nullable fields, rename canBeNull to optional#56
Open
netux wants to merge 1 commit intomrbandler:masterfrom
Open
feat(parser): Generate nullable fields, rename canBeNull to optional#56netux wants to merge 1 commit intomrbandler:masterfrom
canBeNull to optional#56netux wants to merge 1 commit intomrbandler:masterfrom
Conversation
This is different from optional fields (`field?: type`) in that we can use `null` as a value instead of writing the property altogether.
For example:
```ts
interface MyType {
optionalField?: boolean;
nullableField: boolean | null;
optionalAndNullableField?: boolean | null;
}
const obj: MyType = {
// no optionalField here is fine, TypeScript won't complain
nullableField: null, // this is fine as well, TypeScript won't complain
optionalAndNullableField: null // this is fine as well, but we could also not include this field and TypeScript wouldn't complain either
}
```
Renamed old `canBeNull` to `optional` to be able to reuse `canBeNull` for the new functionality.
I didn't know what to do on action.func.ts, so I just defaulted `canBeNull` to false whenever TypeScript complained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is different from optional fields (
field?: type) in that we can usenullas a value instead of writing the property altogether.For example:
Renamed old
canBeNulltooptionalto be able to reusecanBeNullfor the new functionality.I didn't know what to do on action.func.ts, so I just defaulted
canBeNullto false.