Conversation
…onoun detection; add tests
…; clarify Codex workflow
…ate STATUS & Design Intent
…lper in docs README
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| # This file must be used with "source bin/activate" *from bash* | ||
| # You cannot run it directly | ||
|
|
||
| deactivate () { | ||
| # reset old environment variables | ||
| if [ -n "${_OLD_VIRTUAL_PATH:-}" ] ; then | ||
| PATH="${_OLD_VIRTUAL_PATH:-}" | ||
| export PATH | ||
| unset _OLD_VIRTUAL_PATH | ||
| fi | ||
| if [ -n "${_OLD_VIRTUAL_PYTHONHOME:-}" ] ; then | ||
| PYTHONHOME="${_OLD_VIRTUAL_PYTHONHOME:-}" | ||
| export PYTHONHOME | ||
| unset _OLD_VIRTUAL_PYTHONHOME | ||
| fi | ||
|
|
||
| # Call hash to forget past commands. Without forgetting | ||
| # past commands the $PATH changes we made may not be respected | ||
| hash -r 2> /dev/null | ||
|
|
||
| if [ -n "${_OLD_VIRTUAL_PS1:-}" ] ; then | ||
| PS1="${_OLD_VIRTUAL_PS1:-}" | ||
| export PS1 | ||
| unset _OLD_VIRTUAL_PS1 | ||
| fi | ||
|
|
||
| unset VIRTUAL_ENV | ||
| unset VIRTUAL_ENV_PROMPT | ||
| if [ ! "${1:-}" = "nondestructive" ] ; then | ||
| # Self destruct! | ||
| unset -f deactivate | ||
| fi | ||
| } | ||
|
|
||
| # unset irrelevant variables | ||
| deactivate nondestructive |
There was a problem hiding this comment.
[P1] Avoid committing the local .venv environment
The commit adds the entire virtual environment under .venv/ (for example, the new bin/activate script and hundreds of vendored packages and .pyc files). These artefacts are generated per machine and Python version, bloat the repository by hundreds of thousands of lines, and will quickly go stale. They should live in an ignored directory and be recreated from requirements.txt instead.
Useful? React with 👍 / 👎.
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.11' | ||
| - name: Install deps (if requirements.txt) | ||
| run: | | ||
| if [ -f requirements.txt ]; then | ||
| python -m pip install --upgrade pip | ||
| pip install -r requirements.txt | ||
| fi | ||
| - name: Run pytest if tests are present | ||
| run: | | ||
| if ls -1 tests test_*.py 2>/dev/null | grep -q .; then | ||
| pip install pytest | ||
| pytest -q | ||
| else | ||
| echo "No python tests found; skipping" | ||
| fi | ||
| - name: Sanity | ||
| run: python --version |
There was a problem hiding this comment.
[P1] Python CI no longer runs tests or installs dependencies
The revised CI workflow replaces the previous conditional install and pytest execution with a single python --version step. As a result, none of the Python packages are installed and no tests are executed, so regressions in the Python backend will now ship unnoticed. Unless the project intentionally drops Python coverage, the prior installation and test commands should be retained.
Useful? React with 👍 / 👎.
1 participant
Title:
Summary
Checklist
Validation
1.
2.
Links