Skip to content

Feat/soulfield user services#19

Merged
mrhpython merged 19 commits intomainfrom
feat/soulfield-user-services
Sep 24, 2025
Merged

Feat/soulfield user services#19
mrhpython merged 19 commits intomainfrom
feat/soulfield-user-services

Conversation

@mrhpython
Copy link
Copy Markdown
Owner

Title:

Summary

  • What changed and why (1–3 lines).

Checklist

  • Scope is minimal and focused
  • CI green locally (if applicable)
  • Tests added/updated or not applicable
  • Docs updated or not applicable

Validation

  • Steps to verify manually:
    1.
    2.

Links

  • Related issue: #
  • Context/spec:

Michael added 18 commits September 3, 2025 23:25
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment thread systemd/soulfield.service
Comment on lines +7 to +11
WorkingDirectory=%h/soulfield/backend
# Ensure node is available for the user session
Environment=PATH=%h/bin:/usr/local/bin:/usr/bin:/snap/bin
Environment=NODE_ENV=production
ExecStart=/usr/bin/env node index.cjs
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Fix systemd working directory casing

Both user services set WorkingDirectory=%h/soulfield/backend. The repository is named Soulfield (capital S) in this tree, so a standard clone into ~/Soulfield will leave the configured working directory non‑existent and the units will fail to start with No such file or directory. Consider using the correct case or a configurable path.

Useful? React with 👍 / 👎.

Comment on lines +1 to +20
"""
requests.api
~~~~~~~~~~~~

This module implements the Requests API.

:copyright: (c) 2012 by Kenneth Reitz.
:license: Apache2, see LICENSE for more details.
"""

from . import sessions


def request(method, url, **kwargs):
"""Constructs and sends a :class:`Request <Request>`.

:param method: method for the new :class:`Request` object: ``GET``, ``OPTIONS``, ``HEAD``, ``POST``, ``PUT``, ``PATCH``, or ``DELETE``.
:param url: URL for the new :class:`Request` object.
:param params: (optional) Dictionary, list of tuples or bytes to send
in the query string for the :class:`Request`.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Remove committed virtualenv artifacts

This commit introduces an entire Python virtual environment under .venv/ (e.g. vendored requests and hundreds of compiled bytecode files). These environment artifacts add thousands of files and over 300k lines to the repo, dramatically inflating checkout size and making diffs noisy. They should be ignored via .gitignore rather than committed.

Useful? React with 👍 / 👎.

@mrhpython mrhpython enabled auto-merge (squash) September 24, 2025 16:22
@mrhpython mrhpython merged commit be4ff5b into main Sep 24, 2025
@mrhpython mrhpython deleted the feat/soulfield-user-services branch September 24, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant