Conversation
…onoun detection; add tests
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| # This file must be used with "source bin/activate" *from bash* | ||
| # You cannot run it directly | ||
|
|
||
| deactivate () { | ||
| # reset old environment variables |
There was a problem hiding this comment.
[P0] Remove committed virtualenv artifacts
The diff commits an entire Python virtual environment under .venv/ (e.g. the new activate wrapper and hundreds of MB of site‑packages). These are generated, platform‑specific files that will balloon the repo and continually diverge from developers’ local environments, making merges and reviews noisy. They should be recreated with pip during CI rather than checked in.
Useful? React with 👍 / 👎.
| - name: API health (offline) | ||
| run: | | ||
| DEV_NO_API=1 node backend/index.cjs & | ||
| echo $! > api.pid | ||
| sleep 1 | ||
| curl -fsS http://127.0.0.1:8790/health | tee health.json | ||
| DEV_NO_API=1 node backend/index.cjs & echo $! > api.pid | ||
| for i in {1..20}; do | ||
| if curl -fsS http://127.0.0.1:8790/health >/dev/null; then | ||
| curl -fsS http://127.0.0.1:8790/health | tee health.json; break | ||
| fi | ||
| sleep 0.3 | ||
| done |
There was a problem hiding this comment.
[P1] Fail CI when /health never becomes ready
The new health‑check loop keeps trying curl for up to 20 iterations but never exits with a non‑zero status if the API never responds; after the loop finishes the step still succeeds because the last executed command is sleep. This means CI can pass even when the server fails to start. Consider tracking whether a successful response was observed and exit 1 if not before killing the process.
Useful? React with 👍 / 👎.
|
Closing - this PR is based on a very old repository snapshot and contains hundreds of files including virtual environments. The changes are no longer relevant to current main. |
1 participant
Title:
Summary
Checklist
Validation
1.
2.
Links