Skip to content

ci: Release workflow (tags → GHCR)#4

Merged
mrhpython merged 3 commits intomainfrom
chore/release-workflow-20250903214918Z
Sep 3, 2025
Merged

ci: Release workflow (tags → GHCR)#4
mrhpython merged 3 commits intomainfrom
chore/release-workflow-20250903214918Z

Conversation

@mrhpython
Copy link
Copy Markdown
Owner

Publishes Docker image to GHCR on tag pushes (v*).
Uses GITHUB_TOKEN with packages: write.
Image: ghcr.io/${{ github.repository_owner }}/soulfield:latest and :.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines +23 to +27
- name: Login to GHCR
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Authenticate to GHCR with workflow actor, not repository owner

The login step uses username: ${{ github.repository_owner }} while authenticating with secrets.GITHUB_TOKEN. GitHub issues the workflow token for the triggering actor, not for the repository owner, so when the repo lives under an organization the credentials don’t match and docker/login-action returns 401 and the job never reaches the build stage. Using github.actor (the token’s principal) avoids failed releases whenever a maintainer or automation pushes a tag.

Useful? React with 👍 / 👎.

@mrhpython mrhpython enabled auto-merge (squash) September 3, 2025 22:04
@mrhpython mrhpython merged commit 1cfe77d into main Sep 3, 2025
@mrhpython mrhpython deleted the chore/release-workflow-20250903214918Z branch September 24, 2025 16:40
mrhpython added a commit that referenced this pull request Oct 22, 2025
* ci: add tag-based Docker release to GHCR

* ci: extend release workflow to create GitHub Release with notes

* chore(ci): trigger checks for PR #4

---------

Co-authored-by: Michael <michael@localhost>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant