Fix element-wise comparison for grad_lib_values in write_seq.py#30
Open
josalggui wants to merge 1 commit intomri4all:mainfrom
Open
Fix element-wise comparison for grad_lib_values in write_seq.py#30josalggui wants to merge 1 commit intomri4all:mainfrom
josalggui wants to merge 1 commit intomri4all:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes an issue with element-wise comparison in the write_seq.py code.
Problem
The original code compares the entire list
grad_lib_valuesto the string'g', which results inFalseinstead of an element-wise comparison in some cases depending on python or libraries versions. Whenif any(arb_grad_mask)is called, False gives rise an error, while an empty list works properly.Solution
Updated the code to use a list comprehension to perform element-wise comparison: