'Named Routes for Reverse Routing': documentation update + add a feature.#32
Open
ImpressiveDev wants to merge 2 commits intomrjgreen:masterfrom
Open
'Named Routes for Reverse Routing': documentation update + add a feature.#32ImpressiveDev wants to merge 2 commits intomrjgreen:masterfrom
ImpressiveDev wants to merge 2 commits intomrjgreen:masterfrom
Conversation
ImpressiveDev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation
The documentation was a bit misleading in the 'Named Routes for Reverse Routing' section (leading and trailing slashed are removed).
Also, it contained a error (the second parameter of the
routefunction must be an array),New feature
I often have to add leading/trailing slashes after calling the route function of the RouteCollector. Here is my proposal to add a
wrapWithSlashesparameter to the function.