Add support for named parameter handler resolving.#41
Closed
matt-allan wants to merge 1 commit intomrjgreen:masterfrom
matt-allan:named-parameter-handler
Closed
Add support for named parameter handler resolving.#41matt-allan wants to merge 1 commit intomrjgreen:masterfrom matt-allan:named-parameter-handler
matt-allan wants to merge 1 commit intomrjgreen:masterfrom
matt-allan:named-parameter-handler
Conversation
|
@mrjgreen are you still maintaining this project? I'd like to second this request as I could use this feature (currently just relying on a hacked fork). |
|
Hello @mattsah . Can I ask if you rewrite the whole |
|
@rougin sorry, I essentially abandoned this for AltoRouter -- which had its own set of limitations too. Unfortunately despite having probably 500 routers, the PHP community has few that cover the actual real world uses of routers and are open to active maintenance and development. |
|
@mrjgreen do you mind to merge this request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds support for Handler Resolvers that would prefer to receive an associative array where
name => valuefor parameters.I am using PHP DI for dependency injection which is able to inject parameters by matching the name. Passing an associative array of arguments means I can write a handler resolver like this:
Which allows using routes like this:
I wrote a separate interface to allow adding this behavior without causing any backwards compatibility breaks. You can simply implement the regular
HandlerResolverInterfaceif you do not want a single array of named parameters.Let me know if this is something you would be interested in adding to the library.
Thanks!