fix!: fix mixed case when URI_MAC=true #1399
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When URI_MAC=true, value returned from function name_uri appends the MAC suffix as uppercase to an otherwise lowercase camera name (e.g., backyard-camera-ABCD). This results in "duplicate" MQTT endpoints; one with a lowercase and one with an uppercase MAC suffix, causing MQTT commands to fail. This fixes changes the function so that the return result will be entirely lowercase. Resolves: mrlt8#1382 BREAKING CHANGE: URI change to all lowercase for consistency with current conventions Users whose config includes URI_MAC=true will need to update URIs
DAcodedBEAT
approved these changes
Jan 6, 2025
|
Since mrlt8 has been busy of late, I created a fork and merged the PR changes that have been pending for a while. Not trying to steal thunder, but I needed a stable source for updates. The repo does all the Docker Hub publishing and everything, so feel free to click the ADD ADD-ON REPOSITORY button in the repo or grab the new docker image from here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When URI_MAC=true, value returned from function name_uri appends the MAC suffix as uppercase to an otherwise lowercase camera name (e.g., backyard-camera-ABCD). This results in "duplicate" MQTT endpoints; one with a lowercase and one with an uppercase MAC suffix, causing MQTT commands to fail. This fixes changes the function so that the return result will be entirely lowercase.
Resolves: #1382
BREAKING CHANGE:
URI change to all lowercase for consistency with current conventions
Users whose config includes URI_MAC=true will need to update URIs