Skip to content

fix: android crash when calling thumbhashFromBase64String #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nathan-charles wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: android crash when calling thumbhashFromBase64String #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...eact-native-nitro-image/android/src/main/java/com/margelo/nitro/image/HybridImageUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import android.os.Build
import androidx.annotation.Keep
import com.facebook.common.internal.DoNotStrip
import com.margelo.nitro.core.ArrayBuffer
import java.nio.ByteBuffer
import kotlin.io.encoding.Base64
import kotlin.io.encoding.ExperimentalEncodingApi

Expand Down Expand Up @@ -34,7 +33,6 @@ class HybridImageUtils: HybridImageUtilsSpec() {
@OptIn(ExperimentalEncodingApi::class)
override fun thumbhashFromBase64String(thumbhashBase64: String): ArrayBuffer {
val bytes = Base64.decode(thumbhashBase64)
val buffer = ByteBuffer.wrap(bytes)
return ArrayBuffer.wrap(buffer)
return ArrayBuffer.copy(bytes)
}
}