Time-distributed flexible UNet for 2D and 3D space#2
Open
MarkWrobelUCL wants to merge 1 commit intomainfrom
Open
Time-distributed flexible UNet for 2D and 3D space#2MarkWrobelUCL wants to merge 1 commit intomainfrom
MarkWrobelUCL wants to merge 1 commit intomainfrom
Conversation
aniraman1
approved these changes
Mar 25, 2026
Collaborator
aniraman1
left a comment
aniraman1
left a comment
There was a problem hiding this comment.
Looks good, all the code is very neat! I left some suggestions for moving the code to different parts of the repo
| return tuple(kk // 2 for kk in k) | ||
|
|
||
|
|
||
| class TimeDistributed(nn.Module): |
Collaborator
There was a problem hiding this comment.
I would move all the classes to a separate file (like time_dist.py or something like that)
| from ..layers.layer_util import get_image_layer, get_activation, standardize_spatial_factors, _same_padding_time | ||
| from ..layers.layer_util import MaxPoolTime, UpsampleTime, ConvTime, BatchNormTime, ConvTransTime | ||
|
|
||
| class ImageConvBlockTime(nn.Module): |
Collaborator
There was a problem hiding this comment.
I think the conv blocks and encoder/decoder probably belong in layers rather than models?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.