fix: Support pool_maxsize parameter for concurrent connections #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnixHTTPConnectionPool was not passing maxsize to the parent
HTTPConnectionPool, causing it to always use the default of 1.
This resulted in "Connection pool is full, discarding connection"
warnings when making concurrent requests through a Unix socket.
Changes:
- UnixHTTPConnectionPool now accepts maxsize parameter and passes
it to parent class
- UnixAdapter now accepts pool_maxsize parameter (default 1 for
backwards compatibility) and passes it to UnixHTTPConnectionPool
This allows users to configure larger connection pools for
concurrent request scenarios:
adapter = UnixAdapter(pool_maxsize=10)
session.mount('http+unix://', adapter)
Collaborator
|
Looks good to me, and thanks for the great commit message and PR! |
webknjaz
reviewed
Dec 5, 2025
Collaborator
webknjaz
left a comment
webknjaz
left a comment
There was a problem hiding this comment.
I see at least one more in _new_conn()
Author
|
_new_conn() creates individual connections, not pools. maxsize is a pool-level setting passed to HTTPConnectionPool.init(). The parent _new_conn() |
Collaborator
|
Ah, right. Could you add a test for the change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
UnixHTTPConnectionPoolwas not passingmaxsizeto the parentHTTPConnectionPool, causing it to always use the default of 1. This resulted in noisy "Connection pool is full, discarding connection" warnings when making concurrent requests through a Unix socket.Changes
UnixHTTPConnectionPoolnow acceptsmaxsizeparameter and passes it to parent classUnixAdapternow acceptspool_maxsizeparameter (default 1 for backwards compatibility) and passes it toUnixHTTPConnectionPoolUsage
This allows users to configure larger connection pools for concurrent request scenarios:
Backwards Compatibility
Default value of
pool_maxsize=1preserves existing behavior. Only users who explicitly set a larger pool size will see different behavior.