Support Erlang/OTP 26 and Elixir 1.15 in GitHub CI #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List of changes: - bump actions/checkout to v4 - bump deps, see https://hex.pm/l/PKT1e - mix format - refactor CI to run jobs at min/max Erlang/OTP and Elixir
kianmeng
commented
Nov 11, 2023
| @@ -1,19 +1,14 @@ | |||
| %{ | |||
| "cowboy": {:hex, :cowboy, "1.0.4", "a324a8df9f2316c833a470d918aaf73ae894278b8aa6226ce7a9bf699388f878", [:make, :rebar], [{:cowlib, "~> 1.0.0", [hex: :cowlib, optional: false]}, {:ranch, "~> 1.0", [hex: :ranch, optional: false]}]}, | |||
Contributor
Author
There was a problem hiding this comment.
Run mix deps.unlock --check-unused
** (Mix) Unused dependencies in mix.lock file:
* :cowboy
* :cowlib
* :earmark
* :fs
* :ranch
Error: Process completed with exit code 1.
kianmeng
commented
Nov 11, 2023
| ${{ runner.os }}-mix- | ||
| - run: mix deps.get | ||
|
|
||
| - run: mix format --check-formatted |
Contributor
Author
There was a problem hiding this comment.
$ mix format --check-formatted
** (Mix) mix format failed due to --check-formatted.
The following files are not formatted:
/tmp/cors_plug/lib/cors_plug.ex
|
29 29 | @doc false
30 30 | def call(conn, options) do
31 -| case {options[:send_preflight_response?], conn.method, get_req_header(conn, "access-control-request-method")} do
31 +| case {options[:send_preflight_response?], conn.method,
32 +| get_req_header(conn, "access-control-request-method")} do
32 33 | # Not a CORS preflight request
33 34 | {_, "OPTIONS", []} ->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes: