Skip to content

ACM 22876#4

Open
mshort55 wants to merge 5 commits intomainfrom
ACM-22876
Open

ACM 22876#4
mshort55 wants to merge 5 commits intomainfrom
ACM-22876

Conversation

@mshort55
Copy link
Owner

  • ACM-22876 - RBAC UI Implementation - Roles - Initial page creation with mock data
  • Implemented real clusterrole data by vm role label
  • Added main role page and connected existing role tab sections. Created roles context to reduce k8s api calls and implemented on all pages and tab sections. Improved route names and layout.
  • Moved role files into dedicated directory.
  • Renamed role details files

📝 Summary

Ticket Summary (Title):

Ticket Link:

Type of Change:

  • 🐞 Bug Fix
  • ✨ Feature
  • 🔧 Refactor
  • 💸 Tech Debt
  • 🧪 Test-related
  • 📄 Docs

✅ Checklist

General

  • PR title follows the convention (e.g. ACM-12340 Fix bug with...)
  • Code builds and runs locally without errors
  • No console logs, commented-out code, or unnecessary files
  • All commits are meaningful and well-labeled
  • All new display strings are externalized for localization (English only)
  • (Nice to have) JSDoc comments added for new functions and interfaces

If Feature

  • UI/UX reviewed (if applicable)
  • All acceptance criteria met
  • Unit test coverage added or updated
  • Relevant documentation or comments included

If Bugfix

  • Root cause and fix summary are documented in the ticket (for future reference / errata)
  • Fix tested thoroughly and resolves the issue
  • Test(s) added to prevent regression

🗒️ Notes for Reviewers

…th mock data

Signed-off-by: Matthew Short <mshort@redhat.com>
Signed-off-by: Matthew Short <mshort@redhat.com>
…d roles context to reduce k8s api calls and implemented on all pages and tab sections. Improved route names and layout.

Signed-off-by: Matthew Short <mshort@redhat.com>
Signed-off-by: Matthew Short <mshort@redhat.com>
Signed-off-by: Matthew Short <mshort@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant