Fix: Catch potential exception in PacketInterceptor#544
Open
CrosRoad95 wants to merge 6 commits intomta-slipe:masterfrom
Open
Fix: Catch potential exception in PacketInterceptor#544CrosRoad95 wants to merge 6 commits intomta-slipe:masterfrom
CrosRoad95 wants to merge 6 commits intomta-slipe:masterfrom
Conversation
CrosRoad95
changed the title
NanoBob
requested changes
Oct 6, 2024
| { | ||
| try | ||
| { | ||
| PacketReceivedFailed?.Invoke(ex); |
Member
There was a problem hiding this comment.
What would the use-case be for this event?
Collaborator
Author
There was a problem hiding this comment.
This is just in case you want to log it, i could add logger to NetWrapper otherwise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.