Skip to content

docs: revert cross-field validation to and! with simple comparison; add note for validated-field checks#33

Closed
Copilot wants to merge 2 commits intodocs/readme-improvementsfrom
copilot/sub-pr-32
Closed

docs: revert cross-field validation to and! with simple comparison; add note for validated-field checks#33
Copilot wants to merge 2 commits intodocs/readme-improvementsfrom
copilot/sub-pr-32

Conversation

Copy link

Copilot AI commented Mar 3, 2026

The README's Global Validation example was updated to use let! with post-validated field values, diverging from the intended simple, pre-validated comparison pattern. Reverts that change and adds a forward reference for readers who need the more advanced pattern.

Changes

  • Reverted cross-field block from let! _ = (sequential, post-validated) back to and! _ = (parallel, pre-validated) using withValue vm with a direct field comparison:
    and! _ = validation {
        withValue vm
        disputeWithFact NameMatchesUsername (fun a -> a.Name <> a.Username)
        qed
    }
  • Added note after the example pointing readers to the Cross-Field Validation section for cases where checks must operate on individually-validated values.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…d add note

Co-authored-by: RJSonnenberg <24612120+RJSonnenberg@users.noreply.github.com>
Copilot AI changed the title [WIP] Update README with username and name validation example docs: revert cross-field validation to and! with simple comparison; add note for validated-field checks Mar 3, 2026
@RJSonnenberg RJSonnenberg deleted the copilot/sub-pr-32 branch March 4, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants