Skip to content

Improve JSON parsing robustness #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mtalhaimran wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve JSON parsing robustness #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbc858b
Handle extraneous text when parsing JSON
mtalhaimran Jun 9, 2025
7b88c1d
Merge branch 'main' into r6a50t-codex/fix-errors-in-agency.py
mtalhaimran Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Agents/AI Service/agency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,16 @@ def __init__(self, role: str, prompt: ChatPromptTemplate):
logger.info(f"Loading {role} model: {model_name}")
self.llm = ChatOllama(model=model_name)

@staticmethod
def _parse_json(text: str) -> Any:
"""Extract and parse the first JSON object found in text."""
start = text.find("{")
if start == -1:
raise json.JSONDecodeError("No JSON object found", text, 0)
decoder = json.JSONDecoder()
obj, _ = decoder.raw_decode(text[start:])
return obj

async def run(self, project_json: str, context: Dict[str, Any], timeout: Optional[float] = 60.0) -> Any:
"""
Invoke the LLM with formatted messages and return parsed JSON.
Expand All @@ -176,7 +186,7 @@ async def run(self, project_json: str, context: Dict[str, Any], timeout: Optiona
timeout,
)
raw = getattr(message, "content", message)
parsed = json.loads(raw)
parsed = self._parse_json(raw)
logger.info(f"{self.role} responded successfully")
return parsed
except asyncio.TimeoutError:
Expand Down