Skip to content

fix: treat undefined additionalProperties same false #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: treat undefined additionalProperties same false #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions src/type-mappers/object.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,12 @@ export function extractAdditionalPropertiesType(
if (swaggerType.type && swaggerType.type !== "object") {
return undefined;
}
if (swaggerType.additionalProperties === false) {
Copy link
Owner

@mtennoe mtennoe Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test case for the updated behavior?

return undefined;
}
if (
swaggerType.additionalProperties === undefined ||
swaggerType.additionalProperties === true
swaggerType.additionalProperties === false ||
Copy link
Owner

@mtennoe mtennoe Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the false-case be moved from this if check to the one on line 35 for false?

swaggerType.additionalProperties === true ||
swaggerType.additionalProperties === undefined
) {
// is there an easier way to make an "any" type?
return makeAnyTypeSpec({
Copy link
Owner

@mtennoe mtennoe Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, why are we doing this change and not keeping the same makeAnyTypeSpec behavior?

type: "object",
required: [],
minItems: 0,
title: "any",
properties: {}
});
return undefined;
}
return convertType(swaggerType.additionalProperties, swagger);
}
Expand Down