事業課題2: 実装 #2
Open
事業課題2: 実装 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarakish
reviewed
Jun 23, 2023
tarakish
left a comment
tarakish
left a comment
There was a problem hiding this comment.
ご提出ありがとうございます。
全体的に良く実装できていて概ね問題ないと思います！
細かいですが修正点について2点コメントしましたのでご修正と再提出をお願いします！
Comment on lines
+3
to
+11
| def create | ||
| current_user.follow(params[:user_id]) | ||
| redirect_back fallback_location: users_path | ||
| end | ||
|
|
||
| def destroy | ||
| current_user.unfollow(params[:user_id]) | ||
| redirect_back fallback_location: users_path | ||
| end |
app/views/events/_attendee.html.erb
Outdated
| <%= attendee.name %> | ||
| </div> | ||
| <%= link_to attendee.name, user_path(attendee) %> | ||
| </div> |
Comment on lines
+2
to
+5
| belongs_to :follower, class_name: "User" | ||
| belongs_to :followed, class_name: "User" | ||
| validates :follower_id, presence: true | ||
| validates :followed_id, presence: true |
There was a problem hiding this comment.
念のためfollower_idとfollowed_idで複合ユニーク制約をつけておくと良さそうです。
Owner
Author
|
ご指摘いただきありがとうございます。以下2点修正いたしました。ご確認よろしくお願いいたします。 課題内容に関係ないかもしれませんが、ログインしていない状態でユーザー詳細画面にアクセスした場合にNoMethodErrorが表示されるのが気になったため、app/views/users/show.html.erbを修正しました。 |
|
良いと思います 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【選択した事業課題】
2. 直近一年間で、2回以上もくもく会に参加してくれた人は利用者全体の1%のみ。もくもく会で気の合う仲間を見つけられなかったのではないか？