Read news provider configs from ContentProvider #20
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @mmathieum, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces the capability to fetch news provider configurations from an Android ContentProvider. This change enhances the flexibility and maintainability of how news sources are managed within the application by allowing configurations to be externalized and retrieved at runtime.
Highlights
- New Data Source for News Configurations: The
DataSourceManagernow supports reading news provider configurations dynamically from aContentProvider. - New Utility Method: A new static method,
findNewsProviderConfigs, has been added toDataSourceManager. This method is responsible for querying theContentResolverfor news configuration data and parsing it into aNewsProviderConfigobject.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
| try { | ||
| Uri uri = Uri.withAppendedPath(getUri(authority), NewsProviderContract.CONFIG_PATH); | ||
| cursor = queryContentResolver(context.getContentResolver(), uri, null, null, null, null); | ||
| return NewsProviderConfig.fromCursor(cursor); |
There was a problem hiding this comment.
The cursor object can be null if the ContentResolver query fails to return one. Passing a null cursor to NewsProviderConfig.fromCursor() could result in a NullPointerException if that method doesn't handle it. It's safer to check if the cursor is not null and has data before processing it. This also makes the code more robust and prevents potential crashes.
| return NewsProviderConfig.fromCursor(cursor); | |
| if (cursor != null && cursor.moveToFirst()) { | |
| return NewsProviderConfig.fromCursor(cursor); | |
| } | |
| return null; |
app-android/src/main/java/org/mtransit/android/data/DataSourceManager.java
Outdated
Show resolved
Hide resolved
| cursor = queryContentResolver(context.getContentResolver(), uri, null, null, null, null); | ||
| return NewsProviderConfig.fromCursor(cursor); | ||
| } catch (Exception e) { | ||
| MTLog.w(LOG_TAG, e, "Error!"); |
There was a problem hiding this comment.
The generic "Error!" log message is not very helpful for debugging. Including contextual information, such as the authority being queried, would make it much more useful when investigating issues.
MTLog.w(LOG_TAG, e, "Error while finding news provider config for '%s'!", authority);
…Manager.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
… `<pubDate/>` using "Z" (#20)
…onfig # Conflicts: # commons-android
…onfig # Conflicts: # commons-android
No description provided.