fix for custom fields for includes (many-to-one direction) #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srepmub thank you for your PR. Please fix the formatting and order of the 'included' in the tests. After that, the changes can be merged into the main branch. |
srepmub
force-pushed
the
include_custom_fields_other_direction
branch
from
863bcef to
8979ba8
Compare
|
not entirely sure what you mean, but how about this..? (user1 and user2 are already in the right order though it seems?) |
srepmub
force-pushed
the
include_custom_fields_other_direction
branch
2 times, most recently
from
837d582 to
39855bd
Compare
|
fix a formatting issue. |
srepmub
force-pushed
the
include_custom_fields_other_direction
branch
from
39855bd to
ad7bc3a
Compare
|
not sure why 'black' insists on putting certain things on a single line, but not similar code elsewhere. another attempt :P |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 44 44
Lines 2408 2408
Branches 279 279
=======================================
Hits 2202 2202
Misses 143 143
Partials 63 63
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
okay now 'ruff' fails.. will try to fix |
by passing missing include_fields parameter.
srepmub
force-pushed
the
include_custom_fields_other_direction
branch
from
ad7bc3a to
16e7cf3
Compare
|
sorry for the delay. hope everything passes now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by passing missing include_fields parameter.
fixes issue #101 for me.