Fail build if there are non-zero exit codes in build scripts #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses `set -eo` to stop a build if any part of the `build-production` script returns a non-zero code, even if it's part of a series of pipes. This can be turned off for particular parts of the scripts if necessary, but it seems like a sensible default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
set -eoto stop a build if any part of thebuild-productionscript returns a non-zero code, even if it's part of a series of pipes. This can be turned off for particular parts of the scripts if necessary, but it seems like a sensible default.This caused a problem with a build in GN as a dependency problem did not fail the build but produced an image that would not start.