Modifications on header and search bar.#191
Open
ji-yin wants to merge 2 commits intomuan:gh-pagesfrom
ji-yin:gh-pages
Open
Modifications on header and search bar.#191ji-yin wants to merge 2 commits intomuan:gh-pagesfrom ji-yin:gh-pages
ji-yin wants to merge 2 commits intomuan:gh-pagesfrom
ji-yin:gh-pages
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original header is modified to be an on scroll fixed header. The header are including the following items:
i. search bar
ii. clear search button
iii. emoji group button
iv. twemoji switching button
v. header border bottom line
When the search bar is being focused, the value in the search bar will be cleared.