Skip to content

Create hal_adc.c for MSP430FR4133#24

Open
moranod3 wants to merge 1 commit intomuhlbaier:masterfrom
moranod3:patch-2
Open

Create hal_adc.c for MSP430FR4133#24
moranod3 wants to merge 1 commit intomuhlbaier:masterfrom
moranod3:patch-2

Conversation

@moranod3
Copy link
Copy Markdown
Contributor

New hal_adc.c file for the MSP430FR4133

New hal_adc.c file for the MSP430FR4133
@muhlbaier
Copy link
Copy Markdown
Owner

Looks good, has this been tested?

@moranod3
Copy link
Copy Markdown
Contributor Author

moranod3 commented Mar 28, 2019

I have not tested it with and actual micro-controller as I do not have this specific model, however it does build in CCS with the specific micro-controller selected as a property. I can't imagine anything would change when programming on the micro-controller given that most of the code is based off the TI Resource Center.

Copy link
Copy Markdown
Owner

@muhlbaier muhlbaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be tested before we merge it to master. Will you be able to get access to a MSP430F4133?

@moranod3
Copy link
Copy Markdown
Contributor Author

moranod3 commented Apr 2, 2019

I will check and see if anyone has one they can lend me if not I can order one and do the necessary tests.

@muhlbaier
Copy link
Copy Markdown
Owner

Was this ever tested?

@moranod3
Copy link
Copy Markdown
Contributor Author

moranod3 commented May 8, 2019

This was tested and from what i could tell it worked. I re-used some code that just read the voltage off a thermister. The values I was getting were off, but I think it was due to some calculations in the main. The fact that I was receiving data through the ADC led me to believe that the module was functioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants