Create ultrasonic.c#45
Open
moranod3 wants to merge 1 commit intomuhlbaier:masterfrom
Open
Conversation
Code works for a single sensor, the code for the second sensor is still buggy. The timer for the second sensor does not count at the correct speed.
muhlbaier
requested changes
May 8, 2019
Owner
muhlbaier
left a comment
muhlbaier
left a comment
There was a problem hiding this comment.
This is too processor specific to be acceptable. There should be a hal_ultrasonic.c or similar to implement the processor specific code. You don't need to support more than one processor but the module needs to be portable otherwise it isn't a module it is just a chunk of application specific code.
Contributor
Author
|
What exactly is processor specific, because I know when we presented this you told us the hal_ultrasonic file we had was unnecessary. I'm assuming its the code in the Timer and Port interrupts but not 100% sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code works for a single sensor, the code for the second sensor is still buggy. The timer for the second sensor does not count at the correct speed and still needs to be fixed. Changes made to ultrasonic.h since the Ultrasonic_Init function does not pass filter_t, or the callback into the function in the working code.