[CDN] Fix the UMD build#13928
Conversation
| const commonjsOptions = { | ||
| ignoreGlobal: true, | ||
| include: /node_modules/, | ||
| namedExports: { |
There was a problem hiding this comment.
|
I don't think that this was the root cause of the issue since
Maybe adjust our test to import straight from |
@eps1lon It doesn't "work" either. Using an import raises a warning at build and runtime. At some point, I have tried using a require to make the roll-up warning went away. Now, I know that rollup can fail to build the source correctly without raising. It's not what my experience with webpack has been so far. |
|
A warning at runtime? From rollup? Technically a named import isn't allowed at the moment anyway until |
|
@eps1lon It's good to know. I think that we can keep up with react-redux build system and improve our CI. |
Uses the same solution as reduxjs/react-redux#1062. You can reproduce the error following this link: https://rawgit.com/mui-org/material-ui/master/examples/cdn/index.html. I believe that we should have some kind of test for the umd build!