Serve install.sh from the web app#1990
Closed
princepal9120 wants to merge 1 commit intomultica-ai:mainfrom
Closed
Conversation
|
@princepal9120 is attempting to deploy a commit to the IndexLabs Team on Vercel. A member of the Team first needs to authorize it. |
Closed
Collaborator
|
dup #1949 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://multica.ai/install.shcurrently returns a 404, even though the repo already has an installer script inscripts/install.sh.This PR serves that existing script from the web app at
/install.sh, so the published install URL works without adding another copy of the script or depending on a redirect.What changed:
apps/web/app/install.sh/route.ts.scripts/install.shfrom the repo and returns it astext/x-shellscript.Closes #1984.
Validation:
I also ran a small Node check to verify the route resolves to
scripts/install.sh, and that the script starts with#!/usr/bin/env bashand includesUsage: install.sh.I attempted the targeted web test as well:
corepack pnpm --filter @multica/web test -- app/install.sh/route.test.tsThat could not run in this checkout because dependencies were not installed, and
corepack pnpm install --frozen-lockfilefailed withERR_PNPM_ENOSPCon the runner filesystem.