Skip to content

Fixes #2680 - GetGarageSize returns wrong values #4360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 15, 2025
Merged

Fixes #2680 - GetGarageSize returns wrong values #4360

merged 4 commits into from
Aug 15, 2025

Conversation

MohabCodeX
Copy link
Contributor

Fixes #2680

-- Before
Garage ID: 9
Size (X, Y, Z): 16.566600799561, 6.300048828125, 8.3499755859375
Position (X, Y, Z): 2502.3100585938, -1699.3599853516, 12.432299613953

-- After 
Garage ID: 9
Size (X, Y, Z): 6.300048828125, 8.3499755859375, 4.1343011856079
Position (X, Y, Z): 2502.3100585938, -1699.3599853516, 12.432299613953

  • Change the returned values order. The first value should be the third value.

  • Change how the Z size value is calculated. Just get the current value and subtract the garage Z position from it. (sizeZ - posZ)

@FileEX FileEX added the bugfix Solution to a bug of any kind label Aug 15, 2025
FileEX
FileEX requested changes Aug 15, 2025
View reviewed changes
@FileEX FileEX added the backwards-incompatible Should be merged after the release of 1.7.1 label Aug 15, 2025
@FileEX FileEX merged commit 274d865 into multitheftauto:master Aug 15, 2025
MTABot pushed a commit that referenced this pull request Aug 15, 2025
@github-actions
Synchronize changes from 1.6 master branch [ci skip]
4884a53 
274d865 Fixes #2680 - GetGarageSize returns wrong values (#4360)
@FileEX FileEX added this to the 1.7.1 milestone Aug 15, 2025
@MohabCodeX MohabCodeX deleted the fix/garage-size branch August 16, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FileEX FileEX FileEX approved these changes

Assignees
No one assigned
Labels
backwards-incompatible Should be merged after the release of 1.7.1 bugfix Solution to a bug of any kind
Projects
None yet
Milestone
1.7.1
Development

Successfully merging this pull request may close these issues.

Function GetGarageSize returns wrong values
2 participants
@MohabCodeX @FileEX