Noble's crypto BLS #663

andreibancioiu · 2025-09-22T09:46:49Z

Re-did:

BLS: translate herumi-mcl logic into noble-curves mx-deprecated-sdk-js-wallet#51.

Also see

Use BLS from "noble-crypto", instead of "@multiversx/sdk-bls-wasm" - fork mx-deprecated-sdk-js-wallet#30.

Here, we did a translation of BLS-related components of Herumi (MCL) into Noble Curves components. We did this as a test - no production code was touched yet.

Test vectors: blsVectors.json - download and copy to src/testdata.

In September 2024, we've worked on top of noble-curves v1.6.0. In the meantime, there were released many new versions. We've only managed to upgrade to v1.9.2 so far. The rest will be handled in a separate PR.

andreibancioiu · 2025-09-22T09:55:25Z

src/wallet/nobleBlsToHerumiAdapters.spec.ts

@@ -0,0 +1,1027 @@
+import { FpLegendre, isNegativeLE } from "@noble/curves/abstract/modular";


Did the translation within a test file, to be refactored & moved to production logic when appropriate.

andreibancioiu · 2025-09-22T09:56:23Z

src/wallet/nobleBlsToHerumiAdapters.spec.ts

+        this.timeout(100000);
+
+        const testdataPath = path.resolve(__dirname, "..", "testdata");
+        const filePath = path.resolve(testdataPath, "blsVectors.json");


The JSON file containing the test vectors is currently attached to this PR. We should find a good place for it (it's a bit large).

A few of the "inline" test vectors (explicit, in tests code, not in the JSON file) were took from:

multiversx/mx-chain-crypto-go#40

andreibancioiu · 2025-09-22T09:57:02Z

src/wallet/nobleBlsToHerumiAdapters.spec.ts

+            assert.equal(toHex(actualSignature.bytes), signature);
+            assertG1PointsAreEqual(actualSignature.point, signatureAsPoint);
+
+            assert.isTrue(verified);


To improve the precision of the tests, we also check the points coordinates.

andreibancioiu · 2025-09-22T09:57:51Z

src/wallet/nobleBlsToHerumiAdapters.spec.ts

+    });
+});
+
+function setupG2GeneratorPointsLikeHerumi() {


Necessary, since we use a custom generator for BLS public keys.

andreibancioiu · 2025-09-22T09:59:01Z

package.json

    "ts-node": "9.1.1",
-    "typescript": "4.1.2"
+    "typescript": "5.6.2",
+    "@noble/curves": "1.6.0"


Only as "dev-dependency" for now (no change of production code).

By the way, a lot happened since multiversx/mx-deprecated-sdk-js-wallet#51 (on top of v1.6.0):

https://github.com/paulmillr/noble-curves/releases

Copilot

Pull Request Overview

This PR introduces a translation of BLS-related components from Herumi (MCL) to Noble Curves for compatibility testing. It implements BLS cryptographic operations using Noble Curves library as a test implementation without affecting production code.

Adds comprehensive test suite for BLS compatibility between Noble Curves and Herumi implementations
Implements BLS signature operations including signing, verification, and point mapping
Adds Noble Curves dependency for cryptographic operations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/wallet/blcCompatibility.spec.ts	Complete test suite implementing BLS operations using Noble Curves with Herumi-compatible encoding
package.json	Adds Noble Curves dependency and updates TypeScript version

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-22T10:09:57Z

src/wallet/blcCompatibility.spec.ts

+        const numVectors = 256;
+
+        for (let i = 0; i < numVectors; i++) {
+            console.log(`Running test vector ${i++}`);


The post-increment operator i++ in the console.log statement increments i twice per iteration (once in the for loop, once in console.log), causing the loop to skip test vectors and potentially access undefined array elements.

Suggested change

console.log(`Running test vector ${i++}`);

console.log(`Running test vector ${i}`);

Copilot · 2025-09-22T10:09:58Z

package.json

+    "typescript": "5.6.2",
+    "@noble/curves": "1.6.0"


The @noble/curves dependency should be in devDependencies instead of being placed alongside devDependencies like typescript. The formatting is also inconsistent - it should be on a separate line with proper indentation.

Bad comment. Also, not an issue for now.

Merge feat/next in main Add validators operations

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-22T11:05:14Z

src/wallet/blcCompatibility.spec.ts

+    // *x.getFp0() -= Fp::one();
+
+    x = Fp.neg(x);
+    x -= Fp.ONE;


Direct arithmetic operation on field element. Line 824 should use x = Fp.sub(x, Fp.ONE) instead of x -= Fp.ONE to maintain field arithmetic consistency.

Suggested change

x -= Fp.ONE;

x = Fp.sub(x, Fp.ONE);

Operation was on scalars. But, I am really impressed, decent comment, applied!

Copilot · 2025-09-22T11:05:15Z

src/wallet/blcCompatibility.spec.ts

+    // *x.getFp0() += c2_;
+    let x = Fp.mul(t, w);
+    x = Fp.neg(x);
+    x += c2;


Direct arithmetic operation on field element. Should use x = Fp.add(x, c2) instead of x += c2 to maintain field arithmetic consistency.

Suggested change

x += c2;

x = Fp.add(x, c2);

Operation was on scalars. But, I am really impressed, decent comment, applied!

Copilot · 2025-09-22T11:05:15Z

src/wallet/blcCompatibility.spec.ts

+
+    let x = Fp.sqr(w);
+    x = Fp.inv(x);
+    x += Fp.ONE;


Direct arithmetic operation on field element. Should use x = Fp.add(x, Fp.ONE) instead of x += Fp.ONE to maintain field arithmetic consistency.

Suggested change

x += Fp.ONE;

x = Fp.add(x, Fp.ONE);

Operation was on scalars. But, I am really impressed, decent comment, applied!

Copilot · 2025-09-22T11:05:15Z

src/wallet/blcCompatibility.spec.ts

+    let w = Fp.sqr(t);
+
+    // Herumi code: w += G::b_;
+    w += G1.CURVE.b;


Direct arithmetic operation on field element. Should use w = Fp.add(w, G1.CURVE.b) instead of w += G1.CURVE.b to maintain field arithmetic consistency.

Suggested change

w += G1.CURVE.b;

w = Fp.add(w, G1.CURVE.b);

Thanks, same comment as above! 🍪

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/wallet/blcCompatibility.spec.ts

Copilot · 2025-09-22T11:17:13Z

src/wallet/blcCompatibility.spec.ts

+
+    const point = G1.ProjectivePoint.fromHex(bytesReversed);
+    const isYOdd = Fp.isOdd!(point.py);
+    const yNegated = Fp.neg(point.y);


There's an inconsistency in accessing y-coordinate properties: point.py is used on line 933 while point.y is used on line 934. These should consistently use the same property accessor.

Suggested change

const yNegated = Fp.neg(point.y);

const yNegated = Fp.neg(point.py);

Decent suggestion, thanks, applied.

Copilot

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 12 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-22T12:19:30Z

src/wallet/nobleBlsToHerumiAdapters.ts

+}
+
+// Signs a message, given a secret key.
+export function signMessage(message: Uint8Array, secretKey: Uint8Array): { point: any; bytes: Uint8Array } {


The return type uses any for the point property, which reduces type safety. Consider defining a proper interface or using the specific Noble Curves ProjectivePoint type.

These kind of issues will be resolved once we upgrade to a more recent (the most recent) noble curves. Cannot be done at the moment (quite a few breaking changes).

src/wallet/nobleBlsToHerumiAdapters.ts

Copilot · 2025-09-22T12:19:33Z

package.json

+    "typescript": "5.6.2",
+    "@noble/curves": "1.6.0"


The Noble Curves dependency should be moved from devDependencies to dependencies since it's used in production code (imported in the adapter module).

Adapter module isn't properly advertised (should not be used by client code yet).

… incomplete before).

…od for our need. Thus, replaced with library call.

…becomes deprecated (and seems to break the tests) in Noble Curves v1.9.3.

src/wallet/nobleBlsToHerumiAdapters.ts

Redo multiversx/mx-deprecated-sdk-js-wallet#51.

65d72d7

andreibancioiu self-assigned this Sep 22, 2025

andreibancioiu commented Sep 22, 2025

View reviewed changes

andreibancioiu requested a review from Copilot September 22, 2025 10:09

Copilot AI reviewed Sep 22, 2025

View reviewed changes

andreibancioiu and others added 2 commits September 22, 2025 14:01

Fix test.

0faadd9

Merge pull request #667 from multiversx/feat/next

7e4efd3

Merge feat/next in main Add validators operations

andreibancioiu requested a review from Copilot September 22, 2025 11:03

Copilot AI reviewed Sep 22, 2025

View reviewed changes

Fixes after Copilot review.

86e8a51

andreibancioiu requested a review from Copilot September 22, 2025 11:15

Copilot AI reviewed Sep 22, 2025

View reviewed changes

andreibancioiu and others added 3 commits September 22, 2025 14:38

Fix after review etc.

4653412

Merge branch 'main' into noble-crypto-bls-research

fcf5d87

Split code vs. tests.

33f6405

andreibancioiu requested a review from Copilot September 22, 2025 11:58

Copilot AI reviewed Sep 22, 2025

View reviewed changes

Small refactoring.

5f07745

andreibancioiu requested a review from Copilot September 22, 2025 12:15

Copilot AI reviewed Sep 22, 2025

View reviewed changes

andreibancioiu changed the base branch from main to feat/next September 22, 2025 12:33

andreibancioiu added 5 commits September 22, 2025 15:36

Merge branch 'feat/next' into noble-crypto-bls-research

85afe13

Fix after merge.

3fe5512

Temporarily add "test vectors for bls".

1bea9d6

Noble curves v1.7.0.

7654ca5

Noble curves v1.8.0.

a796a2a

andreibancioiu added 5 commits September 22, 2025 18:33

Noble curves v1.8.2.

432699a

Noble curves v1.9.0. Noble curves has fixed "FpLegendre" (was somehow…

14acfae

… incomplete before).

Noble curves v1.9.1. Also, seems like "G.weierstrassEquation()" is go…

c5afd1d

…od for our need. Thus, replaced with library call.

Noble curves v1.9.2.

6bfb910

Add back "getWeierstrassLikeHerumi", since "G.weierstrassEquation()" …

68c1a5e

…becomes deprecated (and seems to break the tests) in Noble Curves v1.9.3.

andreibancioiu marked this pull request as ready for review September 23, 2025 07:05

AdoAdoAdo reviewed Oct 1, 2025

View reviewed changes

src/wallet/nobleBlsToHerumiAdapters.ts Show resolved Hide resolved

Fix after review (additional comments and tests).

c2481fe

andreibancioiu requested a review from AdoAdoAdo October 1, 2025 20:28

		@@ -0,0 +1,1027 @@
		import { FpLegendre, isNegativeLE } from "@noble/curves/abstract/modular";

	console.log(`Running test vector ${i++}`);
	console.log(`Running test vector ${i}`);

	const yNegated = Fp.neg(point.y);
	const yNegated = Fp.neg(point.py);

Noble's crypto BLS #663

Are you sure you want to change the base?

Noble's crypto BLS #663

Uh oh!

Conversation

andreibancioiu commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

andreibancioiu commented Sep 22, 2025 •

edited

Loading