basic features BigIntOperators module code generator #2216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contract comparison - from fe3caee to 8242bd0
|
andrei-marinica
force-pushed
the
big-num-auto-test
branch
from
d1e428d to
5e550d9
Compare
Coverage SummaryTotals
FilesExpand
|
andrei-marinica
force-pushed
the
big-num-auto-test
branch
from
18c43fd to
a0e88b2
Compare
andrei-marinica
commented
Nov 24, 2025
| use num_traits::{pow, sign::Signed, Zero}; | ||
| use std::convert::TryInto; | ||
|
|
||
| macro_rules! binary_op_method { |
Contributor
Author
There was a problem hiding this comment.
These guys just got moved further below, no changes
There was a problem hiding this comment.
Pull request overview
This PR introduces a comprehensive code generator tool (op-test-gen) that automatically generates BigInt/BigUint operator tests and the BigIntOperators module for the basic-features contract. The generator creates extensive scenario-based tests to validate all arithmetic, bitwise, and shift operators on big numbers.
Key changes include:
- New
op-test-gentool that generates operator test endpoints and mandos test scenarios - Division by zero error handling added to the Rust VM's BigInt operations (
bi_t_divandbi_t_mod) - Generated test scenarios split into arithmetic, bitwise, and shift operations for better organization
Reviewed changes
Copilot reviewed 16 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/op-test-gen/src/*.rs | New code generator tool with operator definitions, endpoint generation, and scenario creation |
| tools/op-test-gen/Cargo.toml | Package configuration for the code generator tool |
| contracts/feature-tests/basic-features/src/big_num_operators.rs | Auto-generated trait with comprehensive operator endpoints for BigInt/BigUint |
| contracts/feature-tests/basic-features/scenarios/*.scen.json | Auto-generated test scenarios for arithmetic, bitwise, and shift operations |
| contracts/feature-tests/basic-features/tests/*_test.rs | Test files updated with new operator tests; slow tests moved to separate file |
| chain/vm/src/host/vm_hooks/vh_handler/vh_managed_types/vh_big_int.rs | Added division by zero checks and reorganized implementation into multiple impl blocks |
| Cargo.toml | Added op-test-gen tool to workspace members |
| Cargo.lock | Updated with op-test-gen dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
contracts/feature-tests/basic-features/tests/basic_features_scenario_rs_slow_test.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 19 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andreiblt1304
approved these changes
Nov 25, 2025
BiancaIalangi
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the big number operators using a new suite of mandos tests. These tests are created using a new code generator (they are large).
There is a very similar programmatic test in the Go VM, but that one cannot be used to test the debugger infrastructure/Rust VM.
The same code generator is now generating the
BigIntOperatorsmodule inbasic-features. This makes sure that no operator is left out (they weren't).By running these tests on the Rust VM, we noticed that division by zero was not properly being handled. This is also fixed.
The ultimate point of this PR is to generate the same kind of tests on NonZeroBigUint in a future PR.
NOTE: for some reason the new tests run extremely slowly on wasmer-experimental. In fact, that whole infrastructure is suspiciously slow. For now, the new tests are specifically not run there (only using mx-scenario-go or the debugger, both of which run fast).