-
-
Notifications
You must be signed in to change notification settings - Fork 21
👷 Enable testing on Python 3.14 #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThis PR enables Python 3.14 testing, updates NumPy version markers for Python 3.11–3.14, adds an Unreleased changelog entry referencing PR #488, and tweaks a GitHub Actions workflow input by removing quotes around a glob path. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
uv.lock
is excluded by!**/*.lock
📒 Files selected for processing (4)
.github/workflows/cd.yml
(1 hunks)CHANGELOG.md
(2 hunks)noxfile.py
(1 hunks)pyproject.toml
(1 hunks)
🔇 Additional comments (5)
.github/workflows/cd.yml (1)
40-40
: Clarify the connection to Python 3.14 support.The removal of quotes around
dist/*
appears unrelated to enabling Python 3.14 testing. While both quoted and unquoted glob patterns are valid, this stylistic change is not mentioned in the PR description or objectives.Could you clarify whether:
- This change is intentionally included as a related fix/improvement?
- There was a specific issue with quoted paths that this resolves?
If this is an unrelated change, consider moving it to a separate PR for clearer change tracking.
CHANGELOG.md (2)
12-14
: LGTM!The changelog entry properly documents the Python 3.14 testing enablement with correct formatting and attribution.
50-50
: LGTM!The PR reference link is correctly added to the links section.
noxfile.py (1)
31-31
: LGTM!The addition of Python 3.14 to
PYTHON_ALL_VERSIONS
correctly enables testing on this version for both thetests
andminimums
nox sessions.pyproject.toml (1)
62-62
: LGTM!The Python 3.14 classifier is correctly added to the project metadata, aligning with the testing enablement.
📝 WalkthroughWalkthroughUpdates CI and packaging configs: adjusts artifact attestation glob in CD workflow, adds Python 3.14 to nox testing matrix, documents this in the changelog, and revises NumPy dependency markers in pyproject. No runtime code changes or public API modifications. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
🔇 Additional comments (6)
Comment |
This PR has to stay open until version 2.9.0 of |
Signed-off-by: Daniel Haag <121057143+denialhaag@users.noreply.github.com>
Version 2.9.0 of |
Description
This PR enables testing on Python 3.14.
Fixes #420
Checklist:
I have added appropriate tests that cover the new/changed functionality.I have updated the documentation to reflect these changes.I have added migration instructions to the upgrade guide (if needed).Summary by CodeRabbit
New Features
Documentation
Chores