📦️ Selectively disable archiving when uploading artifacts#332
📦️ Selectively disable archiving when uploading artifacts#332denialhaag merged 3 commits intomainfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughModified three GitHub Actions workflow files to disable artifact archiving during upload by adding Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/reusable-python-tests.yml:
- Around line 119-120: The artifact glob "coverage-*#" is incorrect and won't
match the generated files named like "coverage-$RUNS_ON.xml"; update the
workflow artifact path so it matches the produced filenames (e.g., change the
path from "coverage-*#" to a pattern that matches the XML files such as
"coverage-*.xml" or the exact variable-expanded name used to produce them like
"coverage-$RUNS_ON.xml"/"coverage-${{ env.RUNS_ON }}.xml") so the artifact
upload step will find and publish the coverage reports.
In `@CHANGELOG.md`:
- Line 50: Fix the malformed inline code span in the changelog entry by
replacing the double opening backticks before reusable-change-detection.yml with
a single backtick and adding a matching closing backtick so the filename reads
`reusable-change-detection.yml`; update the line containing "Remove dedicated
`run-mlir` MLIR output for ``reusable-change-detection.yml ([`#300`])
([**@burgholzer**])" to use proper backticks around
reusable-change-detection.yml.
- Line 14: The entry "📦️ Selectively disable archiving when uploading artifacts
([`#332`]) ([**@denialhaag**])" uses the reference "[`#332`]" but there's no
corresponding link definition in the PR links block; add a markdown reference
for [`#332`] in the PR links section (e.g., add a line like "[`#332`]:
https://github.com/<org>/<repo>/pull/332" or the correct PR URL) so the link
resolves; locate the "[`#332`]" token in CHANGELOG.md and add the matching
reference definition to the existing PR links block.
ℹ️ Review info
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/reusable-python-packaging-sdist.yml.github/workflows/reusable-python-packaging-wheel-build.yml.github/workflows/reusable-python-tests.ymlCHANGELOG.md
Description
This PR selectively disables archiving when uploading artifacts, after such an option was added in the
v7.0.0releaseactions/upload-artifact.Checklist:
I have added appropriate tests that cover the new/changed functionality.I have updated the documentation to reflect these changes.I have added migration instructions to the upgrade guide (if needed).