Skip to content

📦️ Selectively disable archiving when uploading artifacts#332

Merged
denialhaag merged 3 commits intomainfrom
archive-flag
Mar 3, 2026
Merged

📦️ Selectively disable archiving when uploading artifacts#332
denialhaag merged 3 commits intomainfrom
archive-flag

Conversation

@denialhaag
Copy link
Member

@denialhaag denialhaag commented Mar 3, 2026

Description

This PR selectively disables archiving when uploading artifacts, after such an option was added in the v7.0.0 release actions/upload-artifact.

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@denialhaag denialhaag self-assigned this Mar 3, 2026
@denialhaag denialhaag added the enhancement Improvement of an existing feature or request label Mar 3, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2026

Warning

Rate limit exceeded

@denialhaag has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 17 minutes and 57 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 1d828b2 and 9f5fad1.

📒 Files selected for processing (2)
  • .github/workflows/reusable-python-tests.yml
  • CHANGELOG.md
📝 Walkthrough

Walkthrough

Modified three GitHub Actions workflow files to disable artifact archiving during upload by adding archive: false configuration, affecting sdist packaging, wheel builds, and test coverage artifact handling. Updated CHANGELOG with corresponding entry.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Artifact Configuration
.github/workflows/reusable-python-packaging-sdist.yml, .github/workflows/reusable-python-packaging-wheel-build.yml, .github/workflows/reusable-python-tests.yml
Added archive: false to upload-artifact steps to disable archiving. Also modified coverage artifact path pattern from coverage-* to coverage-*# in the tests workflow.
Changelog Update
CHANGELOG.md
Added unreleased "Changed" entry documenting selective artifact archiving disablement. Updated references to setup-mlir and refined wording in existing entries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

continuous integration

Suggested reviewers

  • burgholzer

Poem

🐰 Archives be gone, we say with glee,
No zipping up our artifacts, now they're free!
Workflows so light, our pipelines take flight,
Hopping through CI/CD with pure delight!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: selectively disabling archiving in artifact uploads across workflow files.
Description check ✅ Passed The description includes context, motivation (new v7.0.0 feature), and a complete checklist with appropriate items marked as not applicable.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch archive-flag

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/reusable-python-tests.yml:
- Around line 119-120: The artifact glob "coverage-*#" is incorrect and won't
match the generated files named like "coverage-$RUNS_ON.xml"; update the
workflow artifact path so it matches the produced filenames (e.g., change the
path from "coverage-*#" to a pattern that matches the XML files such as
"coverage-*.xml" or the exact variable-expanded name used to produce them like
"coverage-$RUNS_ON.xml"/"coverage-${{ env.RUNS_ON }}.xml") so the artifact
upload step will find and publish the coverage reports.

In `@CHANGELOG.md`:
- Line 50: Fix the malformed inline code span in the changelog entry by
replacing the double opening backticks before reusable-change-detection.yml with
a single backtick and adding a matching closing backtick so the filename reads
`reusable-change-detection.yml`; update the line containing "Remove dedicated
`run-mlir` MLIR output for ``reusable-change-detection.yml ([`#300`])
([**@burgholzer**])" to use proper backticks around
reusable-change-detection.yml.
- Line 14: The entry "📦️ Selectively disable archiving when uploading artifacts
([`#332`]) ([**@denialhaag**])" uses the reference "[`#332`]" but there's no
corresponding link definition in the PR links block; add a markdown reference
for [`#332`] in the PR links section (e.g., add a line like "[`#332`]:
https://github.com/<org>/<repo>/pull/332" or the correct PR URL) so the link
resolves; locate the "[`#332`]" token in CHANGELOG.md and add the matching
reference definition to the existing PR links block.

ℹ️ Review info

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ebbafc and 1d828b2.

📒 Files selected for processing (4)
  • .github/workflows/reusable-python-packaging-sdist.yml
  • .github/workflows/reusable-python-packaging-wheel-build.yml
  • .github/workflows/reusable-python-tests.yml
  • CHANGELOG.md

@denialhaag denialhaag requested a review from burgholzer March 3, 2026 12:17
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@denialhaag denialhaag merged commit 7456bd2 into main Mar 3, 2026
4 of 5 checks passed
@denialhaag denialhaag deleted the archive-flag branch March 3, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement of an existing feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants