Skip to content

Add acknowledgement deadline #1168906818845353 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add acknowledgement deadline #1168906818845353 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8371ff5
Add ack deadline #1168906818845353
aman00323 Apr 2, 2020
6640a1f
Retrive deadline from config #1168906818845353
aman00323 Apr 9, 2020
82d0694
Update code to get deadline#1168906818845353
aman00323 Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ You can check [Google Cloud PubSub client](http://googlecloudplatform.github.io/
'sub2' => 'topic2',
'sub3' => 'topic2' // Multiple subscriber to single topic
],
// Specify sub for which you want to increase deadline
'deadline' => [
'sub1' => 600, // provide duration that you want to increase
],
'plain_handlers' => [
'plain_sub' => App\Jobs\PlainClass::class // This one for non laravel format messages.
],
Expand Down
9 changes: 9 additions & 0 deletions src/PubSubQueue.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,15 @@ public function pop($subscriber = null)
'returnImmediately' => true,
'maxMessages' => 1,
]);
$queue = $this->getQueue($subscriber);
if ($this->config && $this->config['subscribers'] && $queue && isset($this->config['subscribers'][$queue])) {
$deadline = $this->config['subscribers'][$queue]['deadline'];
foreach($deadline as $key => $row) {
if($key == $queue) {
$subscription->modifyAckDeadline(new Message($messages), $row);
}
}
}

if (!empty($messages) && count($messages) > 0) {
return new PubSubJob(
Expand Down