Use AppInfo to get default filemanager#129
Closed
ryonakano wants to merge 12 commits intomuriloventuroso:masterfrom
ryonakano:use-appinfo
Closed
Use AppInfo to get default filemanager#129ryonakano wants to merge 12 commits intomuriloventuroso:masterfrom ryonakano:use-appinfo
ryonakano wants to merge 12 commits intomuriloventuroso:masterfrom
ryonakano:use-appinfo
Conversation
Contributor
Author
|
Related work in elementary project: elementary/code#1162 |
This option is not working in Flatpak in main branch anyways, so just enable on unsandboxed environment and make the code much simpler.
Contributor
Author
|
The file manager option is not working in Flatpak in the main branch anyways, so I thought we can just enable it on unsandboxed environment and make the code much simpler for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened as draft just for visibility and interest. This won't work in the Flatpak version of the app at the moment.
This PR aims to:
xdg-mimeerror when you launch the app with the Flatpak version (mentioned here)This won't work in the Flatpak version at the moment because
AppInfo.get_default_for_type ()tries to get the default filemanager in the sandboxed environment of Flatpak and returnsnullsince there are no filemanager app installed in that environment. This issue is reported at flatpak/xdg-desktop-portal#574 but have no actions been taken until today.