Fix crash when loading a certain MusicXML file #30698
Open
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
commented
Oct 23, 2025
| double y = item->placeAbove() ? 0.0 : item->staff()->staffHeight(item->tick()); | ||
| const Segment* s = item->segment(); | ||
| const EngravingItem* e = s->element(item->track()); | ||
| const EngravingItem* e = s ? s->element(item->track()) : nullptr; |
There was a problem hiding this comment.
prevent dereferencing a nullptr. We might want to use IF_ASSERF_FAILED()` here
Jojo-Schmitz
commented
Oct 23, 2025
| const MusicXmlExtendedSpannerDesc& spdesc = m_pass2.getSpanner({ ElementType::HAIRPIN, number }); | ||
| if (type == u"start") { | ||
| TextLineBase* b = spdesc.isStopped ? toTextLine(spdesc.sp) : Factory::createTextLine(m_score->dummy()); | ||
| TextLineBase* b = spdesc.isStopped && spdesc.sp->isTextLine() ? toTextLine(spdesc.sp) : Factory::createTextLine(m_score->dummy()); |
There was a problem hiding this comment.
prevent a crash in Debug builds
Jojo-Schmitz
commented
Oct 23, 2025
| starts.push_back(MusicXmlSpannerDesc(b, ElementType::TEXTLINE, number)); | ||
| } else if (type == u"stop") { | ||
| TextLine* b = spdesc.isStarted ? toTextLine(spdesc.sp) : Factory::createTextLine(m_score->dummy()); | ||
| TextLine* b = spdesc.isStarted && spdesc.sp->isTextLine() ? toTextLine(spdesc.sp) : Factory::createTextLine(m_score->dummy()); |
There was a problem hiding this comment.
It so far didn't crash here, but I'd rather be consistent and safe than sorry...
|
I think we should rather try to solve the problem at the source. A fermata with no segment during layout should not happen... |
|
Apparently it does though. Seems gracenotes after are involved somehow |
Jojo-Schmitz
force-pushed
the
xml-toTextLine-crash
branch
from
f8ece57 to
bdb120e
Compare
Jojo-Schmitz
commented
Oct 23, 2025
| if (item->isStyled(Pid::OFFSET)) { | ||
| y += item->offset().y(); | ||
| } | ||
| if (!item->segment()) { |
There was a problem hiding this comment.
prevent dereferencing a nullptr. We might want to use IF_ASSERT_FAILED()` here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #30693