Remove mutex from Inject and introduce ThreadSafeInject
#30750
Merged
+150
−175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
force-pushed
the
inject_threadsafeinject
branch
from
eb879cf to
e0d9a7d
Compare
cbjeukendrup
changed the title
Inject non-lazy and thread-safe, and introduce LazyInject
cbjeukendrup
commented
Oct 28, 2025
Comment on lines
-95
to
-98
| namespace mu { | ||
| template<class I> | ||
| using Inject = kors::modularity::Inject<I>; | ||
| } |
There was a problem hiding this comment.
Maybe this removal is a bit bold, but I think it's not good to reference mu namespace in framework, and typing muse:: is easy enough
99.999999% of all Inject instances are accessed from one thread only, so no mutex is necessary at all. For the few (yet to be discovered) cases where a thread-safe Inject *is* necessary, this introduces `ThreadSafeInject`, which has its own mutex, rather than a global static one, which (I think) is better for performance, and avoids the need for a recursive mutex.
cbjeukendrup
force-pushed
the
inject_threadsafeinject
branch
from
e0d9a7d to
13fe622
Compare
cbjeukendrup
changed the title
Inject non-lazy and thread-safe, and introduce LazyInjectInject and introduce ThreadSafeInject
igorkorsukov
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
99% of all Inject instances are accessed from one thread only, so no mutex is necessary at all.
For the few cases where a thread-safe Inject is necessary, this introduces
ThreadSafeInject, which has its own mutex, rather than a global static one, which (I think) is better for performance, and avoids the need for a recursive mutex.Closes #23805, which was never merged because we were not convinced enough of the practical need for it.