Skip to content

Conversation

musicEnfanthen
Copy link
Member

@musicEnfanthen musicEnfanthen commented May 20, 2024

This PR adds some improvements for the incipit tutorial, including those proposed in #263 by @mfeustle .

This includes :

  • simplifying the note example in step 4;
  • simplifying and improving readability of the xml:ids used in the final step;
  • improving the explanation of the attributes used in the final step;
  • improving the explanation of the referencing mechanism with xml:ids in the final step;
  • fixing a typo in the title of the incipit tutorial in the Spanish translation.

Fixes #263

@musicEnfanthen
Copy link
Member Author

@martha-thomae May I ask you to have a look at the updated Spanish translations?

@musicEnfanthen musicEnfanthen requested a review from kepper May 21, 2024 07:27
@musicEnfanthen musicEnfanthen changed the title fix(tutorials): fix incipit tutorial tutorials: fix incipit tutorial Jul 21, 2024
@rettinghaus
Copy link
Member

@martha-thomae Could you have a look please?

@musicEnfanthen musicEnfanthen requested review from davidrizo and martha-thomae and removed request for martha-thomae September 27, 2024 14:37
@bwbohl
Copy link
Member

bwbohl commented Jan 8, 2025

pinging reviewers

@martha-thomae
Copy link
Contributor

Thanks, Benni, Klaus, and Stefan, I will look at this during this week to get it done :)

Copy link
Contributor

@martha-thomae martha-thomae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor corrections for the writing in Spanish. And one extra paragraph that was missing in the Spanish translation of the English version. Thanks for all your work, @musicEnfanthen!

One small question (@musicEnfanthen, @rettinghaus, @bwbohl), do you remember how could I check from my own fork a branch of another person? Like this branch from Stefan, how can I see it on my fork to be able to run the website and see the changes locally? and also be able to actually make commits here? Thank you!

@bwbohl
Copy link
Member

bwbohl commented Jan 13, 2025

A few minor corrections for the writing in Spanish. And one extra paragraph that was missing in the Spanish translation of the English version. Thanks for all your work, @musicEnfanthen!

One small question (@musicEnfanthen, @rettinghaus, @bwbohl), do you remember how could I check from my own fork a branch of another person? Like this branch from Stefan, how can I see it on my fork to be able to run the website and see the changes locally? and also be able to actually make commits here? Thank you!

@martha-thomae In your above comments you can click the document with-+and- to add a suggestion for the marked lines and add your changes there. Theses then can be committed directly.

I’ll make one example for the deletion of 'del ligado' above (#645 (comment))

@musicEnfanthen
Copy link
Member Author

@martha-thomae Thanks for your review.

You can checkout any branch very easily by using gh cli tools: https://cli.github.com/ . You can then build the branch locally (see CONTRIBUTING.md for manual how to do that).

To propose changes to this PR, as @bwbohl explained, you can click on the "Files changed" tab at the top of this PR and then click on the +/- signs at the beginning of a changed line.

Co-authored-by: Benjamin W. Bohl <b.w.bohl@gmail.com>
Copy link
Contributor

@martha-thomae martha-thomae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bwbohl and @musicEnfanthen for the help! I added now the actual changes :) thank you!

Copy link
Contributor

@martha-thomae martha-thomae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be merged now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Technical issues
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

Tutorials: Suggestions on advanced/incipits tutorial
4 participants