Add config support to wistia-video-element#215
Open
comanzanares wants to merge 1 commit intomuxinc:mainfrom
Open
Add config support to wistia-video-element#215comanzanares wants to merge 1 commit intomuxinc:mainfrom
comanzanares wants to merge 1 commit intomuxinc:mainfrom
Conversation
|
@comanzanares is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a config property to to pass Wistia embed options via
_wq.push({ options }), consistent with other elements like Vimeo, HLS, etc.Merges config into Wistia
optionswith user config taking precedence over attribute-derived defaults.Added params based on Wistia embed options docs.
Updates the example to demonstrate passing config to Wistia works.
Adds a test to ensure config is forwarded into Wistia options.