Skip to content

Bump RuboCop dependency versions and fix new offense #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvz merged 3 commits into from
Mar 28, 2026
Merged

Bump RuboCop dependency versions and fix new offense #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6fda10
Move development dependencies to the Gemfile
mvz Mar 28, 2026
a4b5464
Bump minimum RuboCop dependency versions
mvz Mar 28, 2026
24c16f0
Fix Style/FileOpen offense
mvz Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ AllCops:
NewCops: enable
TargetRubyVersion: 3.2

# Put development dependencies in the gemspec so rubygems.org knows about them
Gemspec/DevelopmentDependencies:
EnforcedStyle: gemspec

# Spaces in strings with line continuations go at the beginning of the line.
Layout/LineContinuationLeadingSpace:
EnforcedStyle: leading
Expand Down
15 changes: 14 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,18 @@

source "https://rubygems.org"

# Specify your gem's dependencies in ghtml2pdf.gemspec
# Runtime dependencies are specified in ghtml2pdf.gemspec
gemspec

group :development, :test do
gem "aruba", "~> 2.3"
gem "cucumber", "~> 10.0"
gem "pdf-reader", "~> 2.9"
gem "rake", "~> 13.0"
gem "rake-manifest", "~> 0.2.0"
gem "rspec", "~> 3.3"
gem "rubocop", "~> 1.86"
gem "rubocop-packaging", "~> 0.6.0"
gem "rubocop-performance", "~> 1.26"
gem "rubocop-rspec", "~> 3.9"
end
8 changes: 5 additions & 3 deletions features/step_definitions/page_property_steps.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@
require "stringio"

Then(/^the file "([^"]*)" should have default page properties$/) do |file|
io = File.open expand_path(file)
reader = PDF::Reader.new(io)
pages = File.open expand_path(file) do |io|
reader = PDF::Reader.new(io)
reader.pages
end

reader.pages.each do |page|
pages.each do |page|
box = page.attributes[:MediaBox]

aggregate_failures "A4 page size" do
Expand Down
11 changes: 0 additions & 11 deletions ghtml2pdf.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,4 @@ Gem::Specification.new do |spec|
spec.add_dependency "gir_ffi", "~> 0.18.0"
spec.add_dependency "gir_ffi-gtk", "~> 0.18.0"
spec.add_dependency "ruby-units", "~> 4.0"

spec.add_development_dependency "aruba", "~> 2.3"
spec.add_development_dependency "cucumber", "~> 10.0"
spec.add_development_dependency "pdf-reader", "~> 2.9"
spec.add_development_dependency "rake", "~> 13.0"
spec.add_development_dependency "rake-manifest", "~> 0.2.0"
spec.add_development_dependency "rspec", "~> 3.3"
spec.add_development_dependency "rubocop", "~> 1.80"
spec.add_development_dependency "rubocop-packaging", "~> 0.6.0"
spec.add_development_dependency "rubocop-performance", "~> 1.25"
spec.add_development_dependency "rubocop-rspec", "~> 3.7"
end