Allow explicit nil namespace on associations #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting namespace to nil on a child element was equivalent to not setting it, as far as #to_xml was concerned. This commit changes that and clears the namespace on the generated element. This fixes #43.
Setting namespace to nil on a model child element was equivalent to not setting it, both for reading and writing. This commit changes that by using an empty namespace when searching for nodes to parse, and by the namespace on the generated element. Part of #43.
mvz
force-pushed
the
nil-namespace-on-association
branch
from
12f9c77 to
5142941
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes setting the :namespace option to nil on child elements clear the namespace for parsing and rendering. Before, the effect was ambiguous, clearing the namespace when parsing scalars, but not having any effect when rendering, or when parsing models.
This fixes #43.