feat: Move config to an external file#32
Open
dvh91 wants to merge 4 commits intomweststrate:masterfrom
Open
Conversation
mweststrate
requested changes
Jul 15, 2020
Owner
mweststrate
left a comment
mweststrate
left a comment
There was a problem hiding this comment.
Awesome, thanks for doing this! Left some comments, I think the init condition isn't entirely correct yet?
| (pkg.devDependencies && pkg.devDependencies["relative-deps"]) || | ||
| (pkg.dependencies && pkg.dependencies["relative-deps"]) | ||
| )) { | ||
| if (config) { |
Owner
There was a problem hiding this comment.
I don't think this condition is not correct, the goal of this step here is to install relative-deps itself to the package if not yet present. Probably should be !config?
| } | ||
|
|
||
| // the other file formats will require complex parsing and it's not in the scope of work. | ||
| const allowedConfigFiles = ['package.json', 'relativeDependenciesrc', 'relativeDependenciesrc.json']; |
Owner
There was a problem hiding this comment.
Looks like this block (248 - 255) of loading and validation config should be a function that is used wherever config is loaded, so for example at line 15 as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved relative-deps config into an external file (
relative-deps.json) and still support the old way of storing the config inpackage.jsonMotivation is that this config is personal and should not be committed to the repo.
Resolve issue #30