Support Yarn v3 (berry)#48
Open
jonstuebe wants to merge 4 commits intomweststrate:masterfrom
Open
Conversation
added 2 commits
November 23, 2021 12:38
updated script to handle yarn berry
elektronik2k5
requested changes
Nov 25, 2021
| const packagedName = fs.readdirSync(dir).find(file => regex.test(file)) | ||
| let packagedName = fs.readdirSync(dir).find(file => regex.test(file)) | ||
|
|
||
| if(hasYarn) { |
Collaborator
There was a problem hiding this comment.
According to the docs, hasYarn is a function.
Have you tested your code on yarn 1 or 2 with these changes?
| let packagedName = fs.readdirSync(dir).find(file => regex.test(file)) | ||
|
|
||
| if(hasYarn) { | ||
| let yarnVersion = spawn.sync(['-v'], { cwd: dir, encoding: "utf8" }); |
Collaborator
There was a problem hiding this comment.
Isn't there a longhand version of the same flag, which will clearly signal the intent of the command? I know that yarn@1 has --version in addition to -v.
| if(hasYarn) { | ||
| let yarnVersion = spawn.sync(['-v'], { cwd: dir, encoding: "utf8" }); | ||
|
|
||
| if(yarnVersion.stdout.replace('\n','').split('.')[0] >= 3) { |
Collaborator
There was a problem hiding this comment.
Non strict comparison with type coercion is a strongly discouraged because it is very error prone. Can we do it in a more safe manner?
Author
There was a problem hiding this comment.
Yeah, I can use a semver parsing library if that works. I'll work on this over the next couple of days.
Add option to specify package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using yarn berry the pack command always outputs
package.tgzinstead of using the package name in the filename. This patch fixes that issue.