Fix simulation file saving and remove hardcoded paths #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Portable saving of simulation images with np.savez
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the halo simulation script by fixing how simulation files are saved and making the save paths portable.
What changed:
-Save files with np.savez instead of object arrays- ensures images and axion masses are stored safely and consistently.
-Removed hardcoded Linux paths- uses project-relative paths so the code works on any system.
Testing:
-Verified files save correctly in the project folder with image and axion_mass.
-Verified folder creation works automatically if missing.
Hi! This is my first contribution to DeepLenseSim!
Any feedback is very welcome, happy to improve it!