Skip to content

Don't add "undefined" attribute to model #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yahasana wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't add "undefined" attribute to model #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions backbone.modelbinding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ var modelbinding = (function(Backbone, _, $) {

this.registerDataBinding = function(model, eventName, callback){
// bind the model changes to the elements

model.bind(eventName, callback);
this.modelBindings.push({model: model, eventName: eventName, callback: callback});
};
Expand All @@ -83,7 +83,7 @@ var modelbinding = (function(Backbone, _, $) {
modelBinding.Configuration = function(options){
this.bindingAttrConfig = {};

_.extend(this.bindingAttrConfig,
_.extend(this.bindingAttrConfig,
modelBinding.Configuration.bindindAttrConfig,
options
);
Expand All @@ -98,8 +98,8 @@ var modelbinding = (function(Backbone, _, $) {
}
}

this.getBindingAttr = function(type){
return this.bindingAttrConfig[type];
this.getBindingAttr = function(type){
return this.bindingAttrConfig[type];
};

this.getBindingValue = function(element, type){
Expand Down Expand Up @@ -180,6 +180,7 @@ var modelbinding = (function(Backbone, _, $) {
var element = view.$(this);
var elementType = _getElementType(element);
var attribute_name = config.getBindingValue(element, elementType);
if(typeof attribute_name === "undefined") return true;

var modelChange = function(changed_model, val){ element.val(val); };

Expand Down Expand Up @@ -224,6 +225,7 @@ var modelbinding = (function(Backbone, _, $) {
view.$(selector).each(function(index){
var element = view.$(this);
var attribute_name = config.getBindingValue(element, 'select');
if(typeof attribute_name === "undefined") return true;

var modelChange = function(changed_model, val){ element.val(val); };

Expand All @@ -248,7 +250,7 @@ var modelbinding = (function(Backbone, _, $) {
var attr_value = model.get(attribute_name);
if (typeof attr_value !== "undefined" && attr_value !== null) {
element.val(attr_value);
}
}

// set the model to the form's value if there is no model value
if (element.val() != attr_value) {
Expand Down Expand Up @@ -276,6 +278,8 @@ var modelbinding = (function(Backbone, _, $) {
var element = view.$(this);

var group_name = config.getBindingValue(element, 'radio');
if(typeof group_name === "undefined") return true;

if (!foundElements[group_name]) {
foundElements[group_name] = true;
var bindingAttr = config.getBindingAttr('radio');
Expand Down Expand Up @@ -337,6 +341,7 @@ var modelbinding = (function(Backbone, _, $) {
var element = view.$(this);
var bindingAttr = config.getBindingAttr('checkbox');
var attribute_name = config.getBindingValue(element, 'checkbox');
if(typeof attribute_name === "undefined") return true;

var modelChange = function(model, val){
if (val){
Expand Down