Add missing #include <stdbool.h>#36
Merged
Pansanel merged 3 commits intomychem:masterfrom Jan 30, 2025
Merged
Conversation
#include <stdbool.h>.#include <stdbool.h>
Contributor
|
Thanks for reporting the issue. Is it not sufficient to add the missing header only in the header files? |
Contributor
Author
Good point, I have not tried that, I directly followed GCC advice. Will check. |
Contributor
Author
|
You were right, it is enough to add the missing header to header files. |
Contributor
Author
|
Updated the PR accordingly. |
Contributor
|
The file |
Contributor
Author
Good catch, removed. |
Contributor
|
I thank you for your contribution. I can merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNU 14.2.0 CXX compiler on Debian unstable complains about missing
#include <stdbool.h>in a bunch of*.hfiles, for example:This PR makes mychem-code compile successfully for me.