This repository was archived by the owner on Jan 17, 2019. It is now read-only.
fix bug in IE/Edge for not support native .closest(), use jQuery instead#87
Open
w2wjochem wants to merge 2 commits intomyclabs:masterfrom
Open
fix bug in IE/Edge for not support native .closest(), use jQuery instead#87w2wjochem wants to merge 2 commits intomyclabs:masterfrom
w2wjochem wants to merge 2 commits intomyclabs:masterfrom
Conversation
|
I am having the same issue, could you please merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
In IE/Edge when using the
submit-formoption the submit event wil not fire because of javascript error: "Object doesn't support property or method 'closest'". Because IE/Edge does not support the vanilla feature export yet (see: http://caniuse.com/#feat=element-closest).Fix:
Make the e.target element a jQuery object so it can use the jQuery .closest() method.