Fix infinite loop for token format#5
Merged
myleshyson merged 3 commits intomyleshyson:release/1.0.1from Jun 26, 2025
Merged
Conversation
Owner
|
thanks for reporting! |
Contributor
Author
|
I do not know how to run the generator to test but I have updated that part and reverted types.go Edit: Oh I see from the workflow. So we'll need to figure out what the type is (uint32 or string) but it's a little more involved for me to figure out. Might take a little longer to get that in there. |
Contributor
Author
|
Ok I think this works now. I am newer to Go though so let me know if there is some other tests we could add to test the JSON marshaling. |
Owner
|
Ok this is merged in now and released at 1.0.1. Thanks again 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am setting up ClientCapabilties like
but it causes it to loop infinitely when converting to JSON. Due to the protocol.TokenFormat.
This change converts the type into a string which prevents it from looping infinitely. I am not 100% sure if this is the best fix it but does fix it.
Thanks!