-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add priority mailbox delivery fields #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a0a0c7a to
29c61bb
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
=======================================
Coverage 53.24% 53.24%
=======================================
Files 691 693 +2
Lines 9746 9762 +16
Branches 694 694
=======================================
+ Hits 5189 5198 +9
- Misses 3872 3879 +7
Partials 685 685 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joerivanveen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
De coverage is vrij laag en ik denk dat dit veld op zich wel makkelijk aan bestaande tests is toe te voegen? Of is er een bezwaar tegen?
apps/admin/src/forms/shipmentOptions/fields/createPriorityDeliveryField.ts
Outdated
Show resolved
Hide resolved
FreekVR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verder OK, maar zie de opmerking van Joeri, dat graag nog even checken
INT-1309