Skip to content

Conversation

@GravendeelJochem
Copy link
Contributor

INT-1309

@GravendeelJochem GravendeelJochem force-pushed the feat(JS-PDK)/add-priority-mailbox-delivery branch from a0a0c7a to 29c61bb Compare January 8, 2026 09:18
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.24%. Comparing base (37f8e98) to head (b9e71e8).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pmentOptions/fields/createPriorityDeliveryField.ts 33.33% 4 Missing ⚠️
...ps/admin/src/forms/helpers/isPackageTypeMailbox.ts 50.00% 2 Missing ⚠️
...forms/shipmentOptions/createShipmentOptionsForm.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #290   +/-   ##
=======================================
  Coverage   53.24%   53.24%           
=======================================
  Files         691      693    +2     
  Lines        9746     9762   +16     
  Branches      694      694           
=======================================
+ Hits         5189     5198    +9     
- Misses       3872     3879    +7     
  Partials      685      685           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@joerivanveen joerivanveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De coverage is vrij laag en ik denk dat dit veld op zich wel makkelijk aan bestaande tests is toe te voegen? Of is er een bezwaar tegen?

@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Jan 13, 2026
Copy link
Contributor

@FreekVR FreekVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verder OK, maar zie de opmerking van Joeri, dat graag nog even checken

@myparcel-bot myparcel-bot bot added approved (Auto) and removed changes requested (Auto) labels Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved (Auto)

Development

Successfully merging this pull request may close these issues.

4 participants