-
Notifications
You must be signed in to change notification settings - Fork 7
feat: implement API key-based proposition detection #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
============================================
- Coverage 48.20% 47.98% -0.23%
- Complexity 589 629 +40
============================================
Files 149 151 +2
Lines 3742 3870 +128
Branches 55 55
============================================
+ Hits 1804 1857 +53
- Misses 1883 1958 +75
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6d2c810 to
971fcb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements API key-based proposition detection for the MyParcel PrestaShop plugin, enabling dynamic hook registration and content rendering based on API key validation. It introduces a minimal PDK boot system that allows the settings page to render even without an API key, ensuring proper user onboarding experience.
Key changes:
- Dynamic proposition detection using API key validation
- Minimal PDK boot system for improved onboarding flow
- Namespace migration service for backwards compatibility from "myparcelnl" to "myparcelcom"
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| myparcelnl.php | Updates module namespace to use PdkBootstrapper constant and adds namespace migration |
| src/Service/PdkContextService.php | New service for conditional PDK component rendering and minimal boot context |
| src/Service/NamespaceMigrationService.php | New service for migrating configuration from old to new namespace |
| src/Service/ModuleHookService.php | New service for centralized hook registration with complete hook list |
| src/Hooks/HasPdkRenderHooks.php | Updates hook methods to use conditional rendering based on context |
| config/routes.yml | Updates all route names from "myparcelnl" to "myparcelcom" |
| tests/ | Updates test fixtures and mocks to support new namespace system |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ffbd1c3 to
45c2708
Compare
16f852d to
2d7485e
Compare
016a851 to
b60c1dd
Compare
2484bd2 to
07fa98b
Compare
95b5c50 to
5d5e2c7
Compare
33acd0a to
9fb0d62
Compare
e42c5df to
a591bb4
Compare
9fe7b56 to
4a2b8ff
Compare
4a2b8ff to
51c9b8a
Compare
- Add dynamic proposition detection based on API key validation - Implement minimal PDK boot system - Add namespace migration service for proposition-based configuration - Complete hook system implementation with all required methods Resolves API key proposition detection requirements
…d due to missing state
removes platform-specific builds (distributed zips) per platform as the platform will be fetched in runtime in the plugin itself fixes INT-1051
bump to v4 rather than a new v2 version due to issues with the versioning
- Add dynamic proposition detection based on API key validation - Implement minimal PDK boot system - Add namespace migration service for proposition-based configuration - Complete hook system implementation with all required methods Resolves API key proposition detection requirements
51c9b8a to
73c5fd4
Compare
|
✅ Build successful! You can find a link to the downloadable artifact below.
|
Resolves INT-1049
Needs specific PDK version.