Skip to content

Conversation

@NabDevs
Copy link
Contributor

@NabDevs NabDevs commented Sep 8, 2025

  • Add dynamic proposition detection based on API key validation
  • Implement minimal PDK boot system
  • Add namespace migration service for proposition-based configuration
  • Complete hook system implementation with all required methods

Resolves INT-1049

Needs specific PDK version.

@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 52.07101% with 81 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.98%. Comparing base (519edb8) to head (65d5e2f).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Service/NamespaceMigrationService.php 49.33% 38 Missing ⚠️
src/Service/PdkContextService.php 0.00% 21 Missing ⚠️
myparcelnl.php 47.05% 9 Missing ⚠️
src/Pdk/Base/PsPdkBootstrapper.php 62.50% 6 Missing ⚠️
src/Grid/Column/MyParcelOrderColumn.php 0.00% 2 Missing ⚠️
src/Hooks/HasPsCarrierListHooks.php 0.00% 2 Missing ⚠️
src/Controller/SettingsController.php 0.00% 1 Missing ⚠️
src/Pdk/Installer/Service/PsInstallerService.php 0.00% 1 Missing ⚠️
src/Pdk/Webhook/Service/PsWebhookService.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #391      +/-   ##
============================================
- Coverage     48.20%   47.98%   -0.23%     
- Complexity      589      629      +40     
============================================
  Files           149      151       +2     
  Lines          3742     3870     +128     
  Branches         55       55              
============================================
+ Hits           1804     1857      +53     
- Misses         1883     1958      +75     
  Partials         55       55              
Flag Coverage Δ
backend 75.67% <52.07%> (-1.89%) ⬇️
frontend 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joerivanveen joerivanveen force-pushed the feat/proposition-apikey branch from 6d2c810 to 971fcb5 Compare September 16, 2025 15:09
@joerivanveen joerivanveen marked this pull request as ready for review September 16, 2025 19:47
@joerivanveen joerivanveen requested a review from a team as a code owner September 16, 2025 19:47
Copilot AI review requested due to automatic review settings September 16, 2025 19:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements API key-based proposition detection for the MyParcel PrestaShop plugin, enabling dynamic hook registration and content rendering based on API key validation. It introduces a minimal PDK boot system that allows the settings page to render even without an API key, ensuring proper user onboarding experience.

Key changes:

  • Dynamic proposition detection using API key validation
  • Minimal PDK boot system for improved onboarding flow
  • Namespace migration service for backwards compatibility from "myparcelnl" to "myparcelcom"

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
myparcelnl.php Updates module namespace to use PdkBootstrapper constant and adds namespace migration
src/Service/PdkContextService.php New service for conditional PDK component rendering and minimal boot context
src/Service/NamespaceMigrationService.php New service for migrating configuration from old to new namespace
src/Service/ModuleHookService.php New service for centralized hook registration with complete hook list
src/Hooks/HasPdkRenderHooks.php Updates hook methods to use conditional rendering based on context
config/routes.yml Updates all route names from "myparcelnl" to "myparcelcom"
tests/ Updates test fixtures and mocks to support new namespace system

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@joerivanveen joerivanveen force-pushed the feat/proposition-apikey branch from ffbd1c3 to 45c2708 Compare September 16, 2025 20:05
@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Sep 24, 2025
@joerivanveen joerivanveen self-assigned this Sep 25, 2025
@myparcel-bot myparcel-bot bot force-pushed the feat/proposition-apikey branch 2 times, most recently from 16f852d to 2d7485e Compare October 2, 2025 08:11
@joerivanveen joerivanveen force-pushed the feat/proposition-apikey branch 2 times, most recently from 016a851 to b60c1dd Compare October 2, 2025 12:39
@myparcel-bot myparcel-bot bot removed the changes requested (Auto) label Oct 3, 2025
@myparcel-bot myparcel-bot bot added the approved (Auto) label Oct 7, 2025
@myparcel-bot myparcel-bot bot force-pushed the feat/proposition-apikey branch 3 times, most recently from 2484bd2 to 07fa98b Compare October 16, 2025 08:39
@myparcel-bot myparcel-bot bot force-pushed the feat/proposition-apikey branch from 95b5c50 to 5d5e2c7 Compare October 28, 2025 09:56
@myparcel-bot myparcel-bot bot force-pushed the feat/proposition-apikey branch from 33acd0a to 9fb0d62 Compare November 6, 2025 10:29
@myparcel-bot myparcel-bot bot force-pushed the feat/proposition-apikey branch from e42c5df to a591bb4 Compare November 14, 2025 10:54
@FreekVR FreekVR force-pushed the feat/proposition-apikey branch 4 times, most recently from 9fe7b56 to 4a2b8ff Compare January 21, 2026 17:16
@FreekVR FreekVR force-pushed the feat/proposition-apikey branch from 4a2b8ff to 51c9b8a Compare January 21, 2026 17:20
NabDevs and others added 18 commits January 21, 2026 17:27
- Add dynamic proposition detection based on API key validation
- Implement minimal PDK boot system
- Add namespace migration service for proposition-based configuration
- Complete hook system implementation with all required methods

Resolves API key proposition detection requirements
removes platform-specific builds (distributed zips) per platform as the platform will be fetched in runtime in the plugin itself

fixes INT-1051
bump to v4 rather than a new v2 version due to issues with the versioning
- Add dynamic proposition detection based on API key validation
- Implement minimal PDK boot system
- Add namespace migration service for proposition-based configuration
- Complete hook system implementation with all required methods

Resolves API key proposition detection requirements
@myparcel-bot myparcel-bot bot force-pushed the feat/proposition-apikey branch from 51c9b8a to 73c5fd4 Compare January 21, 2026 17:27
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Jan 23, 2026

✅ Build successful!

You can find a link to the downloadable artifact below.

Name Link
Commit 65d5e2f
Logs https://github.com/myparcelnl/prestashop/actions/runs/21279827853
Download https://github.com/myparcelnl/prestashop/suites/55186905039/artifacts/5231044796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved (Auto)

Development

Successfully merging this pull request may close these issues.

5 participants